Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 support #236

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix PHP 8.4 support #236

merged 1 commit into from
Dec 16, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 6, 2024

No description provided.

@mvorisek mvorisek marked this pull request as ready for review December 6, 2024 00:18
@mvorisek
Copy link
Contributor Author

mvorisek commented Dec 6, 2024

@freekmurze can you please merge and tag a new release?

@freekmurze
Copy link
Member

The tests are failing, could you take a look?

@mvorisek
Copy link
Contributor Author

I have very limited time now, I cannot further work on the compatibility.

@freekmurze freekmurze merged commit 9470b37 into spatie:main Dec 16, 2024
11 of 12 checks passed
@freekmurze
Copy link
Member

Thanks!

@mvorisek mvorisek deleted the php84_support branch December 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants